Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

9 translate the preferred client mode names #10

Merged
merged 15 commits into from
Jan 11, 2023
Merged

9 translate the preferred client mode names #10

merged 15 commits into from
Jan 11, 2023

Conversation

lukasmatusiewicz
Copy link
Contributor

  • Add translation
  • Update tests

@lukasmatusiewicz lukasmatusiewicz self-assigned this Dec 22, 2022
@lukasmatusiewicz lukasmatusiewicz linked an issue Dec 22, 2022 that may be closed by this pull request
Translate the preferred_client_mode names #9
Closed
@lukasmatusiewicz lukasmatusiewicz mentioned this pull request Dec 27, 2022
Open
nilsbehlen
nilsbehlen requested changes Jan 2, 2023
View reviewed changes
Tests/Tests.cs Outdated
@@ -12,6 +13,8 @@ public class Tests
{
WireMockServer server;
PrivacyIDEA privacyIDEA;
private readonly string authToken = "eyJ0eXAiOiJ...KV1QiLC6chGIM";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_AuthToken

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

98fb81a

Tests/Tests.cs Outdated
@@ -208,79 +261,13 @@ public void TriggerChallenges()
.WithPath("/validate/triggerchallenge")
.UsingPost()
.WithBody("user=test")
.WithHeader("Authorization", authToken)
.WithHeader("Authorization", this.authToken)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be _AuthToken. Can drop the this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

98fb81a

Tests/Tests.cs Outdated
.WithPath("/validate/triggerchallenge")
.UsingPost()
.WithBody("user=testwebauthn")
.WithHeader("Authorization", this.authToken)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

98fb81a

@lukasmatusiewicz lukasmatusiewicz linked an issue Jan 6, 2023 that may be closed by this pull request
Add action to run tests for every PR #5
Closed
@lukasmatusiewicz lukasmatusiewicz removed the request for review from nilsbehlen January 9, 2023 09:02
@lukasmatusiewicz
Copy link
Contributor Author

77.1% test coverage

@lukasmatusiewicz lukasmatusiewicz removed the request for review from nilsbehlen January 10, 2023 11:15
@lukasmatusiewicz
Copy link
Contributor Author

81.6% code coverage

@lukasmatusiewicz
Copy link
Contributor Author

ready to review

nilsbehlen
nilsbehlen requested changes Jan 10, 2023
View reviewed changes
PrivacyIDEA_Client/PrivacyIDEA.cs Outdated
@@ -355,7 +355,11 @@ public void SetServiceAccount(string user, string pass, string realm = "")
{
_serviceUser = user;
_servicePass = pass;
if (string.IsNullOrEmpty(realm) is false)
if (string.IsNullOrEmpty(realm))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_serviceRealm = realm ?? "";

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

26f9b42

Tests/TestTriggerChallenges.cs Outdated
[TestMethod]
public async Task TriggerChallenges()
{
// Test no service account
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you extract each of the comments to a function with that name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8d9d7b4

@lukasmatusiewicz
Copy link
Contributor Author

85.9% code coverage

Ready for review

@nilsbehlen nilsbehlen merged commit 688888d into main Jan 11, 2023
@lukasmatusiewicz lukasmatusiewicz deleted the 9-translate-the-preferred_client_mode-names branch January 23, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsbehlen nilsbehlen Awaiting requested review from nilsbehlen

Assignees

@lukasmatusiewicz lukasmatusiewicz

Labels
ready to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translate the preferred_client_mode names Add action to run tests for every PR
2 participants
@lukasmatusiewicz @nilsbehlen