Send requests asynchronously #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lukasmatusiewicz
commented
Nov 1, 2022
•
lukasmatusiewicz
commented
- Suit some main functions to Task-based Async Pattern. This will allow requests to be sent asynchronously or even canceled while the operation is still in progress (optional use).
- Name private fields up to the convention.
- Include nullability.
- Remove redundant files from the repo and add them to .gitignore.
- Code formatting.
- update private parameters names - change sendRequest() to async - change triggerChallenges() to async
- make PollTransaction async - add cancellation token to TriggerChallenge
- sort parameters of SendRequest - add await to all GetAuthToken calls - add cancellation token to all async requests
lukasmatusiewicz
changed the title
some unwanted files was commited in the past and git are following their changes despite adding them to .gitignore. rm from git cache is necessary to repair it.
lukasmatusiewicz
changed the title
nilsbehlen
requested changes
Nov 22, 2022
There was a problem hiding this comment.
we should probably merge #4 then look at this again since there is some overlap -> merge conflicts
|
Ready to review:) |
nilsbehlen
approved these changes
Jan 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.