Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding AggregationServiceTools to help with Aggregation Service codelab. #137

Merged
merged 6 commits into from
Oct 2, 2023
Merged

Adding AggregationServiceTools to help with Aggregation Service codelab. #137

merged 6 commits into from
Oct 2, 2023

Conversation

maybellineboon
Copy link
Contributor

Prior to creating a pull request, please follow all the steps in the contributing guide.

Description

Adding Tools for Aggregation Service to help with Aggregation Service codelab.

Code for AggregationServiceTools is the code for AggregationServiceTools.jar.

Related Issue

  • Fixes #xxx

Affected services

  • Home
  • News
  • Shop
  • Travel
  • DSP
  • SSP
  • ALL

Other:

Copy link

@linkabi9 linkabi9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Remove the unused/unnecessary getFileNameFromPath() from AvroEncoder

All else LGTM

…ecessary lines of code and non-necessary methods.
…o but not necessarily need to be scoped for runtime
@maybellineboon maybellineboon merged commit d0374e6 into privacysandbox:main Oct 2, 2023
@maybellineboon maybellineboon deleted the aggregation-service-tools branch October 2, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants