Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update deployment docs & run fmt #199

Merged
merged 5 commits into from
Nov 16, 2023
Merged

update deployment docs & run fmt #199

merged 5 commits into from
Nov 16, 2023

Conversation

Seburan
Copy link
Contributor

@Seburan Seburan commented Nov 15, 2023

Description

  • update deployment doc with instructions related to enrollment and attestations (how to bypass for local testing)
  • fun fmt on dsp codebase
  • run fmt on tools/

Affected services

  • Home
  • News
  • Shop
  • Travel
  • DSP
  • SSP
  • ALL

Other:

  • Documentation

siddharth-sahoo
siddharth-sahoo approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@siddharth-sahoo siddharth-sahoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of nits: single quotes are preferable for string.

@Seburan Seburan merged commit 877313e into privacysandbox:dev Nov 16, 2023
@Seburan Seburan deleted the fix-attestation-doc branch November 16, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddharth-sahoo siddharth-sahoo siddharth-sahoo approved these changes

@maybellineboon maybellineboon Awaiting requested review from maybellineboon

Assignees

@maybellineboon maybellineboon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Seburan @siddharth-sahoo @maybellineboon