Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing the start command in package.json #537

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

sidneyzanetti
Copy link

Prior to creating a pull request, please follow all the steps in the contributing guide.

Description

There was an error in the docker start command

Affected services

  • Home
  • News
  • Shop
  • Travel
  • DSP
  • SSP
  • ALL

Other:

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:

This pull request, submitted by sidneyzanetti, aims to fix an error in the start command within the package.json file. The error was a redundant docker command before docker-compose up.

Here's a breakdown of the changes:

  • File Changed: package.json
  • Specific Change: The start script in package.json was modified. The line:
"start": "docker docker-compose up",

was changed to:

"start": "docker-compose up",

This removes the unnecessary docker command, simplifying the execution of the start command. The rest of the package.json file remains unchanged.

The pull request description indicates that this change affects all services.

I'll provide a more detailed review shortly. In the meantime, please review the changes and let me know if you have any questions.


A little haiku to lighten the mood:

Start command fixed now,
Docker smoothly starts its dance,
Code flows, clean and bright.

Copy link

Gemini encountered an error creating the review. You can try again by commenting @code-review-assist review.

@sidneyzanetti
Copy link
Author

@code-review-assist review

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request fixes the start command in package.json. The extra "docker" prefix was causing the command to fail. Removing it allows docker-compose up to function correctly. The description clearly explains the issue and correctly identifies all services as affected. I've also included some minor suggestions below and in the README to improve clarity and consistency.

@Seburan Seburan self-assigned this Jan 29, 2025
Copy link
Contributor

@Seburan Seburan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the fix.

@Seburan Seburan merged commit 4a75b48 into privacysandbox:dev Jan 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants