Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deployment config for DSP-X DSP-Y SSP-X SSP-Y #539

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

Seburan
Copy link
Contributor

@Seburan Seburan commented Jan 29, 2025

Description

  • remove unused environment variable
  • fix filename of attestation files for dev and prod
  • fix cloud build config for ssp-x, ssp-y

Related Issue

  • Fixes #xxx

Affected services

  • Home
  • News
  • Shop
  • Travel
  • DSP
  • DSP-X
  • DSP-Y
  • SSP
  • SSP-X
  • SSP-Y
  • ALL

Other:

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:

This pull request, authored by Seburan, aims to update the deployment configuration for DSP-X, DSP-Y, SSP-X, and SSP-Y. The changes include:

  • Removal of unused environment variables: Several unused environment variables related to internal hostnames (e.g., SSP_A_HOST_INTERNAL, SSP_B_HOST_INTERNAL, SSP_X_HOST_INTERNAL, SSP_Y_HOST_INTERNAL) have been removed from the .env, cicd/.env.prod files (lines 77, 83, 89, 95 in .env; lines 89, 95 in cicd/.env.prod).
  • Filename correction for attestation files: The pull request corrects the filenames of attestation files for both development and production environments. (Note: The exact files and changes are not specified in the provided diff, so further investigation may be needed.)
  • Cloud build configuration fixes for SSP-X and SSP-Y: The cicd/cloudbuild.yaml file has been modified to fix the cloud build configuration for SSP-X and SSP-Y. Specifically, lines 372 and 389 were changed to use SSP_X_HOST and SSP_Y_HOST respectively for determining the HOSTNAME environment variable.
  • Changes to deployment scripts: The scripts/cloudrun_deploy.sh, scripts/firebase_deploy.sh, and scripts/firebase_setup.sh scripts were updated to source the correct .env files (lines 18-19 in all three files). The change simplifies the sourcing of environment variables by using a single source file.

Affected Services: DSP-X, DSP-Y, SSP-X, and SSP-Y are directly impacted.

Related Issue: Fixes #xxx (The actual issue number needs to be filled in)

I'll provide a more detailed review shortly. Until then, please review the summary above.

And now, a little haiku to brighten your day:

Code flows like a stream,
Fixes merge, a gentle hum,
Software takes flight.

@Seburan Seburan merged commit b9a092c into privacysandbox:ba-infrastructure Jan 29, 2025
2 checks passed
Copy link

Gemini encountered an error creating the review. You can try again by commenting @code-review-assist review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant