Fix rust 1.78 clippy warnings #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am still having trouble locally with the sharded shuffle shuttle test, curious if that also shows up in CI. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1035 +/- ##
==========================================
+ Coverage 90.24% 90.56% +0.31%
==========================================
Files 172 173 +1
Lines 25727 26089 +362
==========================================
+ Hits 23218 23627 +409
+ Misses 2509 2462 -47 ☔ View full report in Codecov by Sentry. |
akoshelev
reviewed
May 2, 2024
| @@ -99,7 +99,7 @@ check "Web tests" \ | |||
| cargo test -p ipa-core --no-default-features --features "cli web-app real-world-infra test-fixture descriptive-gate" | |||
|
|
|||
| check "Concurrency tests" \ | |||
| cargo test -p ipa-core --release --features shuttle | |||
| cargo test -p ipa-core --release --features "shuttle multi-threading" | |||
There was a problem hiding this comment.
not sure if this is an accidental change or no - I don't have a preference which test to run as long as we run both on CI
There was a problem hiding this comment.
This was intentional, trying to make pre-commit closer to what CI is running.
akoshelev
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.