Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEID-2625 Added Image Options to PAI Client #47

Merged
merged 11 commits into from
Aug 7, 2024
Merged

DEID-2625 Added Image Options to PAI Client #47

merged 11 commits into from
Aug 7, 2024

Conversation

AmirPAI
Copy link
Contributor

@AmirPAI AmirPAI commented Aug 6, 2024 •
edited
Loading

What's Changed?

  • Added ImageOptions class
  • Added to Base64 route
  • Added to URI route
  • Added 8 Unit Tests for request object of ImageOptions
  • Added Integration test

PR Checklist

  • Updated unit tests
  • Ran unit tests

a-guiducci
a-guiducci approved these changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@a-guiducci a-guiducci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you update the appropriate CHANGELOG section before merging please :)

letmerecall
letmerecall approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@letmerecall letmerecall left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @AmirPAI, just some nitpicks in addition to Adam's comment. Otherwise LGTM.

src/privateai_client/components/request_objects.py Outdated Show resolved Hide resolved
src/privateai_client/components/request_objects.py Outdated Show resolved Hide resolved
src/privateai_client/tests/test_request_objects.py Outdated Show resolved Hide resolved
src/privateai_client/tests/test_request_objects.py Outdated Show resolved Hide resolved
@AmirPAI AmirPAI changed the title Deid 2625 python client doesnt contain image options DEID-2625 Added Image Options to PAI Client Aug 6, 2024
@AmirPAI
Copy link
Contributor Author

AmirPAI commented Aug 6, 2024

Thanks @a-guiducci @letmerecall for the review. Do check if the CHANGELOG update is good.

@a-guiducci
Copy link
Collaborator

Looks good, thanks @AmirPAI!

@AmirPAI AmirPAI merged commit b51b88c into main Aug 7, 2024
@letmerecall
Copy link
Member

fixes #42

@letmerecall letmerecall mentioned this pull request Aug 7, 2024
Closed
@bryanbellsmith bryanbellsmith deleted the DEID-2625-python-client-doesnt-contain-image-options branch October 18, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-guiducci a-guiducci a-guiducci approved these changes

@letmerecall letmerecall letmerecall approved these changes

@yaysummeriscoming yaysummeriscoming Awaiting requested review from yaysummeriscoming

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AmirPAI @a-guiducci @letmerecall