fix(resolver): handle importing ".."

fixes #626
privatenumber · Aug 1, 2024 · 3cf0b6a · 3cf0b6a
1 parent ca4bf11
commit 3cf0b6a
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/src/cjs/api/module-resolve-filename/resolve-implicit-extensions.ts b/src/cjs/api/module-resolve-filename/resolve-implicit-extensions.ts
@@ -15,8 +15,8 @@ export const createImplicitResolver = (
 ): SimpleResolve => (
 	request,
 ) => {
-	if (request === '.') {
-		request = './';
+	if (request === '.' || request === '..') {
+		request += '/';
 	}
 
 	/**

diff --git a/src/esm/hook/resolve.ts b/src/esm/hook/resolve.ts
@@ -141,8 +141,8 @@ const resolveDirectory: ResolveHook = async (
 	context,
 	nextResolve,
 ) => {
-	if (specifier === '.') {
-		specifier = './';
+	if (specifier === '.' || specifier === '..') {
+		specifier += '/';
 	}
 
 	if (isDirectoryPattern.test(specifier)) {

diff --git a/tests/fixtures.ts b/tests/fixtures.ts
@@ -212,6 +212,7 @@ export const files = {
 		`,
 
 		'period.in.name.ts': 'export { a } from "."',
+		'dotdot/index.ts': 'export { a } from ".."',
 
 		'index.js': 'throw new Error("should not be loaded")',
 	},

diff --git a/tests/specs/smoke.ts b/tests/specs/smoke.ts
@@ -283,6 +283,7 @@ export default testSuite(async ({ describe }, { tsx, supports, version }: NodeAp
 						import '@/ts/';
 						import './ts/period.in.name';
 						import '@/ts/period.in.name';
+						import './ts/dotdot';
 
 						// .jsx
 						import * as jsx from './jsx/index.jsx';
-Original file line number
+Diff line change
@@ Expand Up / @@ -212,6 +212,7 @@ export const files = { @@
     		`,
     		'period.in.name.ts': 'export { a } from "."',
+    		'dotdot/index.ts': 'export { a } from ".."',
     		'index.js': 'throw new Error("should not be loaded")',
     	},
@@ Expand Down @@