perf: check if js needs compilation #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: only Node.js LTS versions v18 and up are now supported
…to cjs-compile-esm-check
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #167
fix #228
At first, I aimed to exclude all
node_modulesin CommonJS's require hook. However, due to the project's goal of converting packages using ESM syntax (import/export) without a Module type to CommonJS syntax (require()), it's not possible to completely ignore node_modules. Nevertheless, I incorporated checks for ESM syntax to prevent unnecessary file compilation to enhance performance. This should also dramatically reduce the__namenot found errors in dependencies.Furthermore, I removed high-resolution source map generation in MagicString due to its time-consuming nature. Even the non-high-resolution version is somewhat slow but I'm not sure if anything can be done here (is there such thing as partial source maps?).