fix: VS Code breakpoint with tsx and Nodejs 20.12.0 does not work #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
privatenumber
requested changes
Apr 4, 2024
| import type { Transformed } from './utils/transform/apply-transformers.js'; | ||
|
|
||
| const inlineSourceMapPrefix = '\n//# sourceMappingURL=data:application/json;base64,'; | ||
| const isPrepareStackTraceExposed = Semver.satisfies(process.versions.node, '>=20.12.0'); |
There was a problem hiding this comment.
Versioned features live here: https://github.com/privatenumber/tsx/blob/develop/src/utils/node-features.ts
Instead of semver, use the isFeatureSupported function
| @@ -18,7 +20,7 @@ export const installSourceMapSupport = () => { | |||
| * | |||
| * https://github.com/nodejs/node/blob/91193825551f9301b6ab52d96211b38889149892/lib/internal/errors.js#L141 | |||
| */ | |||
| && typeof Error.prepareStackTrace !== 'function' | |||
| && isPrepareStackTraceExposed ? typeof Error.prepareStackTrace === 'function' : typeof Error.prepareStackTrace !== 'function' | |||
There was a problem hiding this comment.
Confused what's happening here. It's checking if it's a function, and then if it's not a function.
What are we actually trying to check for here? Can you update the comment?
6 tasks
|
I close my PR and please continue in #518. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #506