-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/session mem leak #134
Conversation
Use __del__ to cleanup session instead of atexit. atexit function will automatically executed upon normal interpreter termination. But in the context of wsgi application, this never been called unless we stop application. While as for __del__, it will be called as part of gc.
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
==========================================
- Coverage 100% 99.94% -0.06%
==========================================
Files 38 38
Lines 1867 1873 +6
Branches 158 158
==========================================
+ Hits 1867 1872 +5
- Misses 0 1 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 38 38
Lines 1867 1888 +21
Branches 158 160 +2
=====================================
+ Hits 1867 1888 +21
Continue to review full report at Codecov.
|
@SakornW - Just to follow up: if you'd like your name to appear in the
Alternatively, you could open a separate PR with that change. Whatever works best for you! Thanks for contributing 😃 |
@SakornW - Added! 😄 |
Fixes #130
Changes proposed in this pull request:
Attention: @prkumar