Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.9.1 #191

Merged
merged 19 commits into from
Feb 8, 2020
Merged

Release v0.9.1 #191

merged 19 commits into from
Feb 8, 2020

Conversation

prkumar
Copy link
Owner

@prkumar prkumar commented Feb 8, 2020

prkumar and others added 19 commits June 6, 2019 18:25
Twisted 19.7.0 drops py3.4 support.
The build failed because differences between how Schema.load()
and Schema.dump() behave between Marshmallow v3 and v2.
Marshmallow v3 released on August 18, after which our builds
starting picking up the newest major release of the library,
which our tests were not ready for.
Our CI build failures are related to pytest-dev/pytest#5903. We initially restricted pytest up to v4.1 in 64952e3 because pytest_twisted wasn't behaving well with the latest version of pytest at the time.
* Add Python 3.7 build to Travis config

* Remove unnecessary commands from tox.ini

For local development, setting up tox to use pipenv to run tests against
two different versions of Python seems unnecessary, since the CI builds
will run against the versions we want already. Further, there are some
known constraints with running pipenv in a multi-python environment and
the cost of getting this to work doesn't seem worth it.

* Add Python 3.8 Travis build
@codecov
Copy link

codecov bot commented Feb 8, 2020

Codecov Report

Merging #191 into stable will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           stable   #191   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          41     41           
  Lines        2170   2175    +5     
  Branches      173    173           
=====================================
+ Hits         2170   2175    +5
Impacted Files Coverage Δ
uplink/builder.py 100% <ø> (ø) ⬆️
uplink/arguments.py 100% <100%> (ø) ⬆️
uplink/helpers.py 100% <100%> (ø) ⬆️
uplink/commands.py 100% <100%> (ø) ⬆️
uplink/converters/marshmallow_.py 100% <100%> (ø) ⬆️
uplink/auth.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff72f3f...a6a9bcd. Read the comment docs.

@prkumar prkumar merged commit d0ff443 into stable Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants