-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.9.1 #191
Merged
Release v0.9.1 #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twisted 19.7.0 drops py3.4 support.
The build failed because differences between how Schema.load() and Schema.dump() behave between Marshmallow v3 and v2. Marshmallow v3 released on August 18, after which our builds starting picking up the newest major release of the library, which our tests were not ready for.
Our CI build failures are related to pytest-dev/pytest#5903. We initially restricted pytest up to v4.1 in 64952e3 because pytest_twisted wasn't behaving well with the latest version of pytest at the time.
* Add Python 3.7 build to Travis config * Remove unnecessary commands from tox.ini For local development, setting up tox to use pipenv to run tests against two different versions of Python seems unnecessary, since the CI builds will run against the versions we want already. Further, there are some known constraints with running pipenv in a multi-python environment and the cost of getting this to work doesn't seem worth it. * Add Python 3.8 Travis build
Codecov Report
@@ Coverage Diff @@
## stable #191 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 41 41
Lines 2170 2175 +5
Branches 173 173
=====================================
+ Hits 2170 2175 +5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
Header
argument from request when its value isNone
.(Header variable is always used, even when default is None #167, Omit
Header
withNone
value from request #169)AttributeError
raised on usage ofuplink.Url
.(using uplink.Url results in an AttributeError #164, Fix uplink.Url by checking url type (fixes #164) #165 by @cognifloyd)
Changed
tests
subpackages from wheel.(Exclude tests subpackages from resulting Python wheel #188 by @daa)