Fix uplink with Python 2.7 #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #223 +/- ##
===========================================
+ Coverage 99.91% 100.00% +0.08%
===========================================
Files 44 44
Lines 2398 2410 +12
Branches 182 342 +160
===========================================
+ Hits 2396 2410 +14
+ Misses 2 0 -2
Continue to review full report at Codecov.
|
…notations Fix @uplink.*Map to not throw error if converter is None
Flake is failing with "B018 Found useless expression." https://app.travis-ci.com/github/prkumar/uplink/jobs/553555288
* Add 3.9 and 3.10 to travis build * Replace 3.10 with 3.10-dev * Update travis to use Ubuntu 18.04 18.04 has 3.10.0 and 3.10.1 according to: https://docs.travis-ci.com/user/languages/python/ * Bump python 3.10 to 3.10.1 in travis * Unpin pytest version Travis build for 3.10.1 failed because of issue in pytest that was fixed in a later release: pytest-dev/pytest#8540
|
I added Python 2.7 to travis CI config, but the build is failing seemingly because of the issue mentioned here: pypa/pipenv#4357 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #217 .
Changes proposed in this pull request:
Attention: @prkumar