-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RetryBackoff
to support custom @retry backoff strategies
#247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #247 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 44 44
Lines 2410 2466 +56
Branches 342 355 +13
=========================================
+ Hits 2410 2466 +56
Continue to review full report at Codecov.
|
Thanks! |
@prkumar I really appreciate your quick work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new base class,
uplink.retry.RetryBackoff
, which can be extended to implement custom backoff strategies. Subclasses can override three methods:get_timeout_after_response(request, response)
: Returns the number of seconds to wait before retrying the request, orNone
to indicate that the given response should be returned.get_timeout_after_exception(request, exc_type, exc_val, exc_tb)
: Returns the number of seconds to wait before retrying the request, orNone
to indicate that the given exception should be raised.handle_after_final_retry()
: Handles any clean-up necessary following the final retry attempt.An instance of a
RetryBackoff
subclass can be provided through thebackoff
argument of the@retry
decorator.#238