Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix asynchronous callback wrapping #257

Closed
wants to merge 1 commit into from
Closed

Fix asynchronous callback wrapping #257

wants to merge 1 commit into from

Conversation

returnnullptr
Copy link

Fixes #256.

Changes proposed in this pull request:

  • Fix threaded_callback to work with async callbacks. This restores behavior that was changed in v0.9.6 (#248).

Attention: @prkumar

@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #257 (2bd62e6) into master (d9aa5b2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #257   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           44        44           
  Lines         2464      2466    +2     
  Branches       358       359    +1     
=========================================
+ Hits          2464      2466    +2     
Impacted Files Coverage Δ
uplink/clients/aiohttp_.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9aa5b2...2bd62e6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected behavior of async response_handler callback
1 participant