Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign StringRenderer Class #528

Closed
jkcoding7 opened this issue Feb 8, 2024 · 0 comments
Closed

Redesign StringRenderer Class #528

jkcoding7 opened this issue Feb 8, 2024 · 0 comments
Assignees
@jkcoding7
Labels
main Issues with the main code base refactoring A proposal to refector or generally improve the code
Milestone
Release 3.8

Comments

@jkcoding7
Copy link
Contributor

The StringRenderer class provides an API to render strings while also managing font preferences for a user and performing font metrics calculations. To achieve a separation of concerns, decouple the management of font preferences from the StringRenderer class.
jkcoding7 added a commit to jkcoding7/JetUML that referenced this issue Feb 8, 2024
@jkcoding7
[prmr#528] Redesign CanvasFont as a Singleton.
8ffedb4
jkcoding7 added a commit to jkcoding7/JetUML that referenced this issue Feb 8, 2024
@jkcoding7
[prmr#528] Fix TypeNodeRenderer not displaying interface text on gui and
2364da6 
add copyright information.
jkcoding7 added a commit to jkcoding7/JetUML that referenced this issue Feb 8, 2024
@jkcoding7
[prmr#528] Fix TextAlignment logic for setting underlining position.
15a4aed
jkcoding7 added a commit to jkcoding7/JetUML that referenced this issue Feb 10, 2024
@jkcoding7
[prmr#528] Redesign CanvasFont as a Singleton.
7eed384
jkcoding7 added a commit to jkcoding7/JetUML that referenced this issue Feb 10, 2024
@jkcoding7
[prmr#528] Fix TypeNodeRenderer not displaying interface text on gui and
d454321 
add copyright information.
jkcoding7 added a commit to jkcoding7/JetUML that referenced this issue Feb 10, 2024
@jkcoding7
[prmr#528] Fix TextAlignment logic for setting underlining position.
beed153
jkcoding7 added a commit to jkcoding7/JetUML that referenced this issue Feb 11, 2024
@jkcoding7
[prmr#528] Add tests for FontMetrics.
bdace8b
jkcoding7 added a commit to jkcoding7/JetUML that referenced this issue Feb 11, 2024
@jkcoding7
[prmr#528] Fix FontMetrics tests.
2e38db2
jkcoding7 added a commit to jkcoding7/JetUML that referenced this issue Feb 11, 2024
@jkcoding7
[prmr#528] Add StringRenderer tests.
a2e5f55
jkcoding7 added a commit to jkcoding7/JetUML that referenced this issue Feb 11, 2024
@jkcoding7
[prmr#528] Redesign CanvasFont as a Singleton.
e3c911a
jkcoding7 added a commit to jkcoding7/JetUML that referenced this issue Feb 11, 2024
@jkcoding7
[prmr#528] Fix TypeNodeRenderer not displaying interface text on gui and
9f655c1 
add copyright information.
jkcoding7 added a commit to jkcoding7/JetUML that referenced this issue Feb 11, 2024
@jkcoding7
[prmr#528] Fix TextAlignment logic for setting underlining position.
33f0d8e
jkcoding7 added a commit to jkcoding7/JetUML that referenced this issue Feb 11, 2024
@jkcoding7
[prmr#528] Add tests for FontMetrics.
adad3c6
jkcoding7 added a commit to jkcoding7/JetUML that referenced this issue Feb 11, 2024
@jkcoding7
[prmr#528] Fix FontMetrics tests.
b3b15e3
jkcoding7 added a commit to jkcoding7/JetUML that referenced this issue Feb 11, 2024
@jkcoding7
[prmr#528] Add StringRenderer tests.
20f0234
jkcoding7 added a commit to jkcoding7/JetUML that referenced this issue Feb 12, 2024
@jkcoding7
[prmr#528] Change CanvasFont INSTANCE to private.
6b8f072
jkcoding7 added a commit to jkcoding7/JetUML that referenced this issue Feb 15, 2024
@jkcoding7
[prmr#528] Redesign StringRenderer class and add unit tests for
2fc22b7 
getHeight.
jkcoding7 added a commit to jkcoding7/JetUML that referenced this issue Feb 15, 2024
@jkcoding7
[prmr#528] Change CanvasFont to Singleton.
dbd40e1
jkcoding7 added a commit to jkcoding7/JetUML that referenced this issue Feb 15, 2024
@jkcoding7
[prmr#528] Add comments to new tests.
c5c8375
@prmr prmr added refactoring A proposal to refector or generally improve the code main Issues with the main code base labels Feb 15, 2024
@prmr prmr added this to the Release 3.8 milestone Feb 15, 2024
jkcoding7 added a commit to jkcoding7/JetUML that referenced this issue Feb 26, 2024
@jkcoding7
[prmr#528] Revert CanvasFont to a non-singleton.
f6579cf
jkcoding7 added a commit to jkcoding7/JetUML that referenced this issue Mar 3, 2024
@jkcoding7
[prmr#528] Fix unit tests for getHeight.
564772a
jkcoding7 added a commit to jkcoding7/JetUML that referenced this issue Mar 3, 2024
@jkcoding7
[prmr#528] Change naming of italics to italic and remove unused imports.
c714514
prmr pushed a commit that referenced this issue Mar 5, 2024
@jkcoding7 @prmr
[#528] Redesign StringRenderer class and add unit tests for
0cb13a7 
getHeight.
prmr pushed a commit that referenced this issue Mar 5, 2024
@jkcoding7 @prmr
[#528] Change CanvasFont to Singleton.
d988ef5
prmr pushed a commit that referenced this issue Mar 5, 2024
@jkcoding7 @prmr
[#528] Add comments to new tests.
3007773
prmr pushed a commit that referenced this issue Mar 5, 2024
@jkcoding7 @prmr
[#528] Revert CanvasFont to a non-singleton.
8a047c5
prmr pushed a commit that referenced this issue Mar 5, 2024
@jkcoding7 @prmr
[#528] Fix unit tests for getHeight.
0a3d4ec
prmr pushed a commit that referenced this issue Mar 5, 2024
@jkcoding7 @prmr
[#528] Change naming of italics to italic and remove unused imports.
471d962
@jkcoding7 jkcoding7 reopened this May 21, 2024
jkcoding7 added a commit to jkcoding7/JetUML that referenced this issue May 21, 2024
@jkcoding7
[prmr#528] Shift the dependency on Fonts from the constructor of Font…
1ca8f9d 
…Metrics

to its methods.
@jkcoding7 jkcoding7 changed the title Redesign StringRenderer Class [#528] Redesign StringRenderer Class May 21, 2024
@jkcoding7 jkcoding7 changed the title [#528] Redesign StringRenderer Class Redesign StringRenderer Class May 21, 2024
jkcoding7 added a commit to jkcoding7/JetUML that referenced this issue Jun 3, 2024
@jkcoding7
[prmr#528] Change FontMetrics to a static utility class, and remove
0be7fcb 
CanvasFont.
jkcoding7 added a commit to jkcoding7/JetUML that referenced this issue Jun 3, 2024
@jkcoding7
[prmr#528] Re-arranged draw method location.
22f769f
jkcoding7 added a commit to jkcoding7/JetUML that referenced this issue Jun 3, 2024
@jkcoding7
[prmr#528] Add assertions and javadocs to FontMetrics.
ad41572
jkcoding7 added a commit to jkcoding7/JetUML that referenced this issue Jun 3, 2024
@jkcoding7
[prmr#528] Remove CSS and Preview for FontDialog.
98bba71
jkcoding7 added a commit to jkcoding7/JetUML that referenced this issue Jun 3, 2024
@jkcoding7
[prmr#528] Remove unused CSS styling.
e9d984f
jkcoding7 added a commit to jkcoding7/JetUML that referenced this issue Jun 4, 2024
@jkcoding7
[prmr#528] Modularize markup check into a method.
09a1bc0
prmr pushed a commit that referenced this issue Jun 11, 2024
@jkcoding7 @prmr
[#528] Change FontMetrics to a static utility class, and remove
b72f1b2 
CanvasFont.
prmr pushed a commit that referenced this issue Jun 11, 2024
@jkcoding7 @prmr
[#528] Re-arranged draw method location.
3d99916
prmr pushed a commit that referenced this issue Jun 11, 2024
@jkcoding7 @prmr
[#528] Add assertions and javadocs to FontMetrics.
f76c5fb
prmr pushed a commit that referenced this issue Jun 11, 2024
@jkcoding7 @prmr
[#528] Remove CSS and Preview for FontDialog.
8fb1695
prmr pushed a commit that referenced this issue Jun 11, 2024
@jkcoding7 @prmr
[#528] Remove unused CSS styling.
8ccffc2
prmr pushed a commit that referenced this issue Jun 11, 2024
@jkcoding7 @prmr
[#528] Modularize markup check into a method.
ca53d73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkcoding7 jkcoding7

Labels
main Issues with the main code base refactoring A proposal to refector or generally improve the code
Projects
None yet
Milestone
Release 3.8
Development

No branches or pull requests
2 participants
@prmr @jkcoding7