fixed refsystem normal basis (was not normalized!) & version bump (so…

…lves scale and annotation problem)
pro3d-space · May 7, 2024 · 5e0adb0 · 5e0adb0
1 parent 429ea17
commit 5e0adb0
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/TEST_RELEASE_NOTES.md b/TEST_RELEASE_NOTES.md
@@ -1,3 +1,6 @@
+## 4.25.0-prerelease4
+- fixed refsystem normalization
+
 ## 4.25.0-prerelease2
 - option for switching euler angle order
 

diff --git a/src/PRo3D.Core/TransformationApp.fs b/src/PRo3D.Core/TransformationApp.fs
@@ -73,10 +73,17 @@ module TransformationApp =
                 | Planet.ENU -> 
                     Trafo3d.FromOrthoNormalBasis(V3d.IOO, V3d.OIO, V3d.OOI) * northCorrection
                 | Planet.Mars ->
-                    let upP = CooTransformation.getUpVector pivot refSystem.planet
-                    let east = V3d.OOI.Cross(upP)
-                    let north = upP.Cross(east)
-                    Trafo3d.FromOrthoNormalBasis(north, east, upP) * northCorrection
+                    //let upP = CooTransformation.getUpVector pivot refSystem.planet
+                    //let east = V3d.OOI.Cross(upP)
+                    //let north = upP.Cross(east)
+                    //Log.line "%A,%A,%A" upP.Length east.Length north.Length
+                    let north = refSystem.northO.Normalized        
+                    let up    = refSystem.up.value.Normalized
+                    let east  = north.Cross(up).Normalized
+
+                    let refSysRotation = 
+                        Trafo3d.FromOrthoNormalBasis(north, east, up)
+                    refSysRotation
                 | Planet.JPL -> 
                     Trafo3d.FromOrthoNormalBasis(-V3d.IOO, V3d.OIO, -V3d.OOI) * northCorrection
                 | Planet.None ->