Stylefile resolve #177
Merged
Stylefile resolve #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #177 +/- ##
=======================================
Coverage 73.32% 73.32%
=======================================
Files 57 57
Lines 3040 3040
Branches 391 391
=======================================
Hits 2229 2229
Misses 660 660
Partials 151 151 Continue to review full report at Codecov.
|
JonathanWenger
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the resolved version of PR #123. It had some nasty merge conflicts in the jupyter notebook, so I just made a quick new draft. The style file is the same, the notebooks are still updated, the increment in each notebook is minimal (essentially, all rcParams are replaced by plt.style.use). Since #164 for instance might change the RV notebooks, I wanted to avoid further merge conflicts in the future, hence the actual plotting code is not touched. @JonathanWenger you might need to take a look at the linear solver plots regarding serif/sans-serif. I only checked whether each notebook ran through.