LinOp arithmetic part 1 #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidtjonathan
added
feature request
Codecov Report
@@ Coverage Diff @@
## main #505 +/- ##
==========================================
+ Coverage 88.49% 89.06% +0.57%
==========================================
Files 175 176 +1
Lines 6301 6612 +311
Branches 805 881 +76
==========================================
+ Hits 5576 5889 +313
+ Misses 501 485 -16
- Partials 224 238 +14
|
schmidtjonathan
force-pushed
the
linop-arithmetic-I
branch
3 times, most recently
from
877c19e
to
7fd67ab
Compare
schmidtjonathan
requested review from
pnkraemer,
JonathanWenger and
marvinpfoertner
schmidtjonathan
force-pushed
the
linop-arithmetic-I
branch
from
d543e01
to
6a7a78e
Compare
marvinpfoertner
requested changes
Aug 15, 2021
schmidtjonathan
force-pushed
the
linop-arithmetic-I
branch
from
6a7a78e
to
a6542fb
Compare
marvinpfoertner
approved these changes
Nov 18, 2021
|
The PR can't be merged because patch coverage is slightly too low. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a Nutshell
Add (efficient) arithmetics for combinations of Linear Operators : Part 1
Detailed Description
For some combinations of linear operators, there exist known arithmetics that can be implemented more efficiently.
E.g.
Kronecker @ Kronecker ~~> Kroneckerinstead of yielding aProductLinearOperatorthat builds up large call stacks.Related Issues
#509 ; mitigates the described problem in parts. (Subsequent PRs will consecutively solve the issue)