-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
making quad
iterator info stateless & adding tests
#659
Merged
mmahsereci
merged 20 commits into
probabilistic-numerics:main
from
mmahsereci:mm-bq-state-refactor
Apr 6, 2022
Merged
making quad
iterator info stateless & adding tests
#659
mmahsereci
merged 20 commits into
probabilistic-numerics:main
from
mmahsereci:mm-bq-state-refactor
Apr 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #659 +/- ##
==========================================
- Coverage 90.02% 90.01% -0.01%
==========================================
Files 194 194
Lines 7337 7343 +6
Branches 1159 1159
==========================================
+ Hits 6605 6610 +5
Misses 489 489
- Partials 243 244 +1
|
tskarvone
reviewed
Mar 29, 2022
tskarvone
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a Nutshell
This PR makes the following changes in
quad
:BQIterInfo
andBQState
: The former is now simply a container for info concerning the loop iteration. The latter contains the BQ belief.BQIterInfo
is now a simple dataclass and also stateless (it wasn't stateless before, and error prone due to inconsistent updating).BQIterInfo
andBQState
as there were no tests at all before.Detailed Description
This PR will be followed up by changes as in #620 .
Related Issues
Closes #...