Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed no-else-return message in probnum.linalg module #699

Closed
wants to merge 4 commits into from

Conversation

peterw2333
Copy link
Contributor

In a Nutshell

Fixed no-else-return message in probnum.linalg module

Detailed Description

Removes unnecessary else after return, and changing unneccessary elif after return to if.
pylint no-else-return(R1705)

Related Issues

Finishes objective 2 in #671

@codecov
Copy link

codecov bot commented Apr 10, 2022

Codecov Report

Merging #699 (3aecd05) into main (cb5b55a) will not change coverage.
The diff coverage is 70.58%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #699   +/-   ##
=======================================
  Coverage   90.02%   90.02%           
=======================================
  Files         194      194           
  Lines        7350     7350           
  Branches     1161     1161           
=======================================
  Hits         6617     6617           
  Misses        489      489           
  Partials      244      244           
Impacted Files Coverage Δ
src/probnum/linalg/solvers/matrixbased.py 73.75% <37.50%> (ø)
...um/linalg/solvers/beliefs/_linear_system_belief.py 91.42% <100.00%> (ø)
...num/linalg/solvers/policies/_conjugate_gradient.py 91.42% <100.00%> (ø)

@JonathanWenger JonathanWenger self-assigned this Apr 10, 2022
@JonathanWenger JonathanWenger added the testing and CI Unit tests, coverage and continuous integration label Apr 10, 2022
Copy link
Contributor

@JonathanWenger JonathanWenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing and CI Unit tests, coverage and continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants