-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Algebraic Operations on Functions
#725
Merged
marvinpfoertner
merged 22 commits into
probabilistic-numerics:main
from
marvinpfoertner:function-algebra
Sep 1, 2022
Merged
Algebraic Operations on Functions
#725
marvinpfoertner
merged 22 commits into
probabilistic-numerics:main
from
marvinpfoertner:function-algebra
Sep 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvinpfoertner
force-pushed
the
function-algebra
branch
from
August 31, 2022 10:21
67c5faf
to
98767d6
Compare
marvinpfoertner
force-pushed
the
function-algebra
branch
from
August 31, 2022 10:22
98767d6
to
1a245c7
Compare
Codecov Report
@@ Coverage Diff @@
## main #725 +/- ##
==========================================
+ Coverage 90.12% 90.27% +0.14%
==========================================
Files 194 197 +3
Lines 7353 7445 +92
Branches 1163 1154 -9
==========================================
+ Hits 6627 6721 +94
- Misses 486 487 +1
+ Partials 240 237 -3
|
marvinpfoertner
force-pushed
the
function-algebra
branch
from
August 31, 2022 14:12
12dcc51
to
6d56c99
Compare
marvinpfoertner
force-pushed
the
function-algebra
branch
from
August 31, 2022 14:38
73b5122
to
d697acb
Compare
marvinpfoertner
requested review from
pnkraemer and
schmidtjonathan
as code owners
August 31, 2022 15:36
JonathanWenger
approved these changes
Aug 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a few clarification questions, but otherwise good to go. Thanks 🙏!
Co-authored-by: Jonathan Wenger <jonathan.wenger@uni-tuebingen.de>
Co-authored-by: Jonathan Wenger <jonathan.wenger@uni-tuebingen.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a Nutshell
This PR implements addition and scalar multiplication on
Function
s.This is a proposal for how to redesign all algebraic structures in ProbNum.
Detailed Description
Function + Function
ScalarLike * Function
functools.singledispatchmethod
to register the correct result for combinations of different function typesRelated Issues
None