-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make quad
integration measures stateless
#748
Make quad
integration measures stateless
#748
Conversation
Codecov Report
@@ Coverage Diff @@
## main #748 +/- ##
==========================================
+ Coverage 90.69% 90.71% +0.02%
==========================================
Files 206 206
Lines 7638 7638
Branches 982 982
==========================================
+ Hits 6927 6929 +2
+ Misses 479 478 -1
+ Partials 232 231 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. As a user, I personally find it a bit annoying to have to provide an rng myself, but there is probably a good reason for this change.
It's mostly in preparation for #581 . See #744 (comment) |
This reverts commit 90b5dd3.
The tox docs build seems to have failed when merging into |
@mmahsereci Should be fixed now in #754 . |
In a Nutshell
This PR removes the default rng from the
quad
integration measures. Further, some long overdue shape tests for the sample method of the measures are added.Detailed Description
na
Related Issues
Closes #...