Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in asrandvar introduced by breaking changes in ScIPy 1.10 #763

Merged

Conversation

JonathanWenger
Copy link
Contributor

In a Nutshell

SciPy 1.10 introduced a Covariance object (see https://scipy.github.io/devdocs/release.1.10.0.html#scipy-stats-improvements), which is being used for multivariate_normal random variables. This caused a bug in the asrandvar function which is handled in this PR.

@JonathanWenger JonathanWenger added the bug Something isn't working label Jan 6, 2023
@JonathanWenger JonathanWenger self-assigned this Jan 6, 2023
@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #763 (c8e329d) into main (30cdee3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #763   +/-   ##
=======================================
  Coverage   90.79%   90.80%           
=======================================
  Files         210      210           
  Lines        7703     7707    +4     
  Branches      986      986           
=======================================
+ Hits         6994     6998    +4     
  Misses        478      478           
  Partials      231      231           
Impacted Files Coverage Δ
src/probnum/randvars/_scipy_stats.py 72.22% <100.00%> (+1.29%) ⬆️

Copy link
Collaborator

@marvinpfoertner marvinpfoertner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏻

@JonathanWenger JonathanWenger merged commit abe8225 into probabilistic-numerics:main Jan 7, 2023
@JonathanWenger JonathanWenger deleted the as-randvar branch January 7, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants