Fix matmul implementation of Zero linop #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matmul result now has the correct shape
timweiland
requested review from
marvinpfoertner and
JonathanWenger
as code owners
Codecov Report
@@ Coverage Diff @@
## main #764 +/- ##
==========================================
+ Coverage 90.80% 90.90% +0.10%
==========================================
Files 210 210
Lines 7707 7709 +2
Branches 986 984 -2
==========================================
+ Hits 6998 7008 +10
Misses 478 478
+ Partials 231 223 -8
|
marvinpfoertner
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a Nutshell
matmul result now has the correct shape
Detailed Description
The Zero linear operator had a bug where in the matmul implementation, it simply returned a zero vector of the same shape of the input. But this does not always match the shape we expect from the matmul output.
Related Issues
Closes #761