Use triangular solves in default _solve
#801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the default `_solve` implementation of `LinearOperator` use triangular solves if the linear operator is lower/upper triangular Add test cases for triangular matrices
timweiland
requested review from
marvinpfoertner and
JonathanWenger
as code owners
Codecov Report
@@ Coverage Diff @@
## main #801 +/- ##
=======================================
Coverage 91.28% 91.29%
=======================================
Files 218 218
Lines 8207 8209 +2
Branches 1059 1060 +1
=======================================
+ Hits 7492 7494 +2
Misses 487 487
Partials 228 228
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a Nutshell
Make use of triangular property in
_solveDetailed Description
_solveimplementation ofLinearOperatoruse triangular solves if the linear operator is known to be lower/upper triangular