feat: Use friendly verbose and colorish #962
Conversation
|
It would currently look like. Terminal
Notebook
VS code
Documentation website
|
MarieS-WiMLDS
force-pushed
the
is/959
branch
from
817f137 to
c563d45
Compare
|
So I switch from a decorator that was implicitly consuming |
There was a problem hiding this comment.
OK, so it should be ready for review.
@MarieS-WiMLDS saw that we could refactor the argument in the CLI and use parent_parser. I don't add it in this PR to have the minimum diff, but it could be worth to do so for maintainability.
Another limitation of argparse here: I cannot pass verbose at the top parser and the subparser to allow skore --verbose launch ... and skore launch --verbose. This is something that click can nicely deal with and it is a pattern allowed in term of UX that I saw in other package (e.g. pixi).
Finally, @MarieS-WiMLDS spotted something weird in the quickstart where we can provide a working_dir for the create part but we don't do any cd for this directory in the launch. So it should fail. I'll try to craft a minimal non-regression test and it can be handled in another PR.
|
@thomass-dev This last run will be fun for you :). In addition of the issue with the coverage (I maybe need to merge main), I segfault in Windows ;) |
thomass-dev
force-pushed
the
main
branch
2 times, most recently
from
beb4b05 to
469d1e5
Compare
|
@thomass-dev I leave to you to merge this? 🙏 |
thomass-dev
force-pushed
the
main
branch
3 times, most recently
from
ef3e8da to
469d1e5
Compare
thomass-dev
force-pushed
the
main
branch
2 times, most recently
from
ad7922d to
469d1e5
Compare
closes #834 Investigate an API for a `EstimatorReport`. #### TODO - [x] Metrics - [x] handle string metrics has specified in the accessor - [x] handle callable metrics - [x] handle scikit-learn scorers - [x] use efficiently the cache as much as possible - [x] add testing for all of those features - [x] allow to pass new validation set to functions instead of using the internal validation set - [x] add a proper help and rich `__repr__` - [x] Plots - [x] add the roc curve display - [x] add the precision recall curve display - [x] add prediction error display for regressor - [x] make proper testing for those displays - [x] add a proper `__repr__` for those displays - [x] Documentation - [x] (done for the checked part) add an example to showcase all the different features - [x] find a way to show the accessors documentation in the page of `EstimatorReport`. It could be a bit tricky because they are only defined once the instance created. - We need to have a look at the `series.rst` page from pandas to see how they document this sort of pattern. - [x] check the autocompletion: when typing `report.metrics.->tab` it should provide the autocompetion. **edit**: having a stub file is actually working. I prefer this than type hints directly in the file. - Open questions - [x] we use hashing to retrieve external set. - use the caching for the external validation set? To make it work we need to compute the hash of potentially big arrays. This might more costly than making the model predict. #### Notes This PR build upon: - #962 to reuse the `skore.console` - #998 to be able to detect clusterer in a consistent manner.
closes #959
closes #812
This PR proposes to:
loggerthat does not show any information by default--verboseoption for the CLI orverboseparameter for the functionsverboseparameterrichconsole with cyan/orange colors (as the defaultskoretheme) for showing the pertinent information.TODO:
logger_contextis behaving as expected.