Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing docstring tests in Julia nightly. #523

Closed
ztangent opened this issue Mar 18, 2024 · 1 comment
Closed

Failing docstring tests in Julia nightly. #523

ztangent opened this issue Mar 18, 2024 · 1 comment

Comments

@ztangent
Copy link
Member

Finally figured out why our nightly CI builds keep failing --- looks like it's due to this upstream issue with how @doc is implemented in the testing environment: JuliaLang/julia#52986

For reference, this is what the failing test looks like:

docstrings: Test Failed at /home/runner/work/Gen.jl/Gen.jl/test/dsl/dynamic_dsl.jl:533
  Expression: String(take!(io)) == "my documentation\n"
   Evaluated: "nothing" == "my documentation\n"

Stacktrace:
 [1] top-level scope
   @ ~/work/Gen.jl/Gen.jl/test/dsl/dynamic_dsl.jl:8
 [2] macro expansion
   @ /opt/hostedtoolcache/julia/nightly/x64/share/julia/stdlib/v1.12/Test/src/Test.jl:164 [inlined]
 [3] macro expansion
   @ ~/work/Gen.jl/Gen.jl/test/dsl/dynamic_dsl.jl:12 [inlined]
 [4] macro expansion
   @ /opt/hostedtoolcache/julia/nightly/x64/share/julia/stdlib/v1.12/Test/src/Test.jl:164 [inlined]
 [5] macro expansion
   @ ~/work/Gen.jl/Gen.jl/test/dsl/dynamic_dsl.jl:21 [inlined]
 [6] macro expansion
   @ /opt/hostedtoolcache/julia/nightly/x64/share/julia/stdlib/v1.12/Test/src/Test.jl:167 [inlined]
Test Summary:                                      | Pass  Fail  Total  Time
Dynamic DSL                                        |  147     1    148  6.5s

Looks like the issue is being actively addressed upstream, so we can just wait for a fix. (Alternatively, we can add REPL as a test dependency, but then we'll have to remove once the upstream issue is fixed.)

ztangent added a commit that referenced this issue Sep 5, 2024
This addresses #523 by handling the new return type of `@doc` on Julia 1.11 nightly builds when the REPL module isn't loaded, which differs from the behavior of `@doc` on earlier versions of Julia.
@ztangent
Copy link
Member Author

ztangent commented Sep 5, 2024

Not fully fixed upstream yet (see JuliaLang/julia#54664), but addressed via a workaround in #542.

@ztangent ztangent closed this as completed Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant