More ruff fixes #77
Merged
More ruff fixes #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sritchie
commented
Jul 23, 2024
| @@ -210,9 +211,6 @@ def cube_mesh(dimensions=jnp.ones(3), color=jnp.array([1.0, 0.0, 0.0])): | |||
| def shape(self): | |||
| return self.vertices.shape[:-1] | |||
|
|
|||
| def __len__(self): | |||
There was a problem hiding this comment.
@nishadgothoskar these were duplicates of code above
sritchie
commented
Jul 23, 2024
| @@ -136,6 +138,7 @@ def _rasterize_bwd(self, saved_tensors, diffs): | |||
| ) | |||
| dy, ddb = diffs | |||
|
|
|||
| # Don't delete! This call has the side-effect of preventing JAX from complaining when we call `grad` on a `Renderer`. | |||
There was a problem hiding this comment.
here's the comment I added addressing our issue from before
sritchie
commented
Jul 23, 2024
| @@ -103,7 +105,7 @@ def downsize_images(ims, k): | |||
|
|
|||
|
|
|||
| @jax.jit | |||
| def xyz_from_depth(z: "Depth Image", fx, fy, cx, cy): | |||
| def xyz_from_depth(z: rr.DepthImage, fx, fy, cx, cy): | |||
There was a problem hiding this comment.
this was a bug, fixed this to refer to the correct type
sritchie
commented
Jul 23, 2024
| @@ -24,17 +25,17 @@ def gt_informed_triangle_proposal(gt_triangle, mindepth, maxdepth, fx, fy, cx, c | |||
| A, B, C = gt_triangle | |||
|
|
|||
| # Origin of the camera frame | |||
| O = jnp.zeros(3) | |||
| origin = jnp.zeros(3) | |||
There was a problem hiding this comment.
fixed an "ambiguous name" linter error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: