Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal mixer mixes linear and not logarithmic #182

Closed
dcoredump opened this issue Apr 27, 2022 · 2 comments
Closed

Internal mixer mixes linear and not logarithmic #182

dcoredump opened this issue Apr 27, 2022 · 2 comments

Comments

@dcoredump
Copy link
Contributor

dcoredump commented Apr 27, 2022

... as the subject says... I think panning is also coded linear (I am not sure if this is right). Should it be also logarithmic?

Will fix this soon for internal mixer class (if noone else wants to do this, because I am currently writing the SYSEX engine).

@probonopd
Copy link
Owner

probonopd commented Apr 27, 2022

Great catch! According to https://sound.stackexchange.com/a/41550,

The MIDI specification itself does not define the exact response to the volume controller.

Nowadays, there is almost no device that does no implement the expression controller. Both the GM Level 1 Developer Guidelines and the DLS specification use L(dB) = 40 log (volume × expression / 127²). Furthermore, the guidelines mention that

there was general agreement about how these two controllers interacted as well: In 9 cases, their values were combined (multiplied) to get the actual level. The recommended volume response curves for CC#7 (volume) and CC#11 (expression) used herein were provided to the General MIDI Working Group of the IASIG/MMA by Yamaha Corporation. Roland uses the same response curve, and other Japanese manufacturers who are members of the AMEI have agreed to do the same.

So this is how almost all devices actually implement it.

@probonopd
Copy link
Owner

Merged. Thank you @dcoredump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants