Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some voices are not played #83

Closed
probonopd opened this issue Apr 10, 2022 · 29 comments
Closed

Some voices are not played #83

probonopd opened this issue Apr 10, 2022 · 29 comments
Assignees
Labels
bug Something isn't working

Comments

@probonopd
Copy link
Owner

probonopd commented Apr 10, 2022

@probonopd probonopd added the bug Something isn't working label Apr 10, 2022
@probonopd
Copy link
Owner Author

probonopd commented Apr 10, 2022

One this mystery is solved, we may consider to create nice performances using the TX816 voices.

For example, set TG1...8 to use Tfi1...8.syx from Dexed_cart_1.0/Original Yamaha/TX816/, each voice 11. (Possibly no additional detune; tbc.) The result is a nice rich piano sound making full use of our 8 tone generators!

@probonopd
Copy link
Owner Author

@dcoredump can you reproduce this issue, also on MicroDexed?

@dcoredump
Copy link
Contributor

I have to check this tomorrow.

@dcoredump
Copy link
Contributor

dcoredump commented Apr 12, 2022

@dcoredump can you reproduce this issue, also on MicroDexed?

Couldn't try, sorry.

Perhaps those sounds use the breath controller for the AMP envelope?

Do they work in VST Dexed?

@probonopd
Copy link
Owner Author

Yes, they work on standalone Dexed on FreeBSD. (Couldn't get the VST to build, yet.)

@dcoredump
Copy link
Contributor

Hm, have to check this... sorry, currently not much free time for this 😢

@probonopd probonopd pinned this issue May 11, 2022
@frank-que
Copy link

frank-que commented Jun 21, 2022

Hello,
I've found where is the problem:
turn left one step "A MOD Sens" on OSC1 and the sounds are back.
In some conditions with "A MOD Sens" on OSC1 at maximum value sounds are muted.

@dcoredump
Copy link
Contributor

Hello, I've found where is the problem: turn left one step "A MOD Sens" on OSC1 and the sounds are back. In some conditions with "A MOD Sens" on OSC1 at maximum value sounds are muted.

Hi @frank-que!

Thanks for finding THIS issue... I will try to fix it inside Synth_Dexed asap.

Regards, Holger

@frank-que
Copy link

@dcoredump
A heartfelt thanks to you and to all of the developers for the amazing work that you are doing!

@dcoredump
Copy link
Contributor

dcoredump commented Jun 22, 2022

@frank-que
Can you tell me for which Bank/Voice this problem encounters?

@frank-que
Copy link

@dcoredump
BANK 3A - SAX BC
BANK 3A - VOICES BC
BANK 4A - BRASS BC
and others...

@frank-que
Copy link

The problem seems derived by combination between "Algorithm" and "A MOD Sens"

@dcoredump
Copy link
Contributor

The problem seems derived by combination between "Algorithm" and "A MOD Sens"

Ok, many thanks!
Does this happen only on "BC" sounds? (BC seems to mean that something (perhaps AMP_MOD) is used by the breath controller)

@frank-que
Copy link

Not only "BC" sounds, another example is "Bank 3A - Train" sounds different than Dexed does.

@dcoredump
Copy link
Contributor

It looks like a bigger problem... I am 90% sure that it is located inside Synth_Dexed. I think it will take some time (for me) to locate the problem. Stay tuned...

@probonopd
Copy link
Owner Author

Thanks for looking into it @dcoredump. Can you reproduce it on the Teensy?

@frank-que
Copy link

@dcoredump
take your time.
I would like to help you, but I don't have enough knowledge to do it.

@dcoredump
Copy link
Contributor

dcoredump commented Jun 23, 2022

Sorry @probonopd - I totally forgot to check if the problems exists on MicroDexed. Now I have done this and the answer is: NO. Bank 3A / SAX BC works fine. Also 3A / TRAIN. I used the latest Synth_Dexed (28ef0da952) and everything is fine.

So the problem seems to be inside MiniDexed. I tried to check the "sysex reading code" and found no problem - but I am pretty sure that the problem must be located at reading sysex data...

@arsamus
Copy link
Contributor

arsamus commented Jun 23, 2022

So the problem seems to be inside MiniDexed. I tried to check the "sysex reading code" and found no problem - but I am pretty sure that the problem must be located at reading sysex data...

An easy way to test this hypotesis is loading, for example, "SAX BC" data on a PC version of Dexed and send it to MiniDexed vía MIDI and see what happends. Bank voice data and individual voice data have different sysex structures. Bank voice data needs to be decoded once received in order to extract all parameters, some parameters share the same byte, on the other hand, individual voice data has one byte for each individual parameter. The issue could be on the decoder algorithm.
If I have some time later I'll try to test this.

@frank-que
Copy link

I've already tested send sysex data from dexed, it was when I found the problem, I use dexed as minidexed frontend.

@arsamus
Copy link
Contributor

arsamus commented Jun 23, 2022

I've already tested send sysex data from dexed, it was when I found the problem, I use dexed as minidexed frontend.

Yes, I've just tested too. In this case, I don't think that it is a SysEx issue...

@probonopd
Copy link
Owner Author

https://yamahablackboxes.com/articles/how-to-program-yamaha-dx7/ says:

When the EG bias for a controller is on, the controller overrides the controller envelopes for which amplitude sensitivity has been programmed. This will be a complete override if the amplitude sensitivity is set to full on (3), while at lower levels (1 or 2) the internal envelope will still have a reduced but audible effect. The full-on setting is especially useful for wind instrument sounds, because you can control their amplitude from the breath controller, giving realistic articulations. You can hold down a note on the keyboard and get no sound until you blow into the breath controller. When EG bias is off but amplitude or pitch control and sensing are on, a controller becomes an LFO amount control.

So it looks like EG bias is on by default in MiniDexed, whereas it should be off by default (and possibly a way should be added to enable it)?

It seems like you came to the same conclusion @arsamus, would be great if you could send a PR. Thanks!

@arsamus
Copy link
Contributor

arsamus commented Jul 3, 2022

Hi everybody, you can test the patch to this fix with this build https://github.com/probonopd/MiniDexed/suites/7193919829/artifacts/287422925

You have to set off Modulation Wheel -> EG Bias on the new "Modulation" menu of each TG

@frank-que
Copy link

frank-que commented Jul 3, 2022

Hi @arsamus , I've tested it on RPI zero, now seems to work, but with some artifacts (I use PCM1502 module).
Probably this is due by RPI zero performance, but it is very strange, because my modified stereo version for RPI zero, with only one TG and reverber active, works well, without artifacts.
I have an RPI4, but I cant'use it for the testing, it is used on my Zynthian.
Thank you for your effort for the project and sorry if my english is not perfect, is not my native language, but I hope you understand what I wrote :)

Frank

@arsamus
Copy link
Contributor

arsamus commented Jul 3, 2022

Hi @arsamus , I've tested it on RPI zero, now seems to work, but with some artifacts (I use PCM1502 module).
Probably this is due by RPI zero performance, but it is very strange, because my modified stereo version for RPI zero, with only one TG and reverber active, works well, without artifacts.
I have an RPI4, but I cant'use it for the testing, it is used on my Zynthian.
Thank you for your effort for the project and sorry if my english is not perfect, is not my native language, but I hope you understand what I wrote :)

Frank

Hi @frank-que. It is very strange because this PR doesn't add any subprocess to the main Process loop respect the Productive version or on Synth Dexed itself. All changes occurs only when you sulf on some menus and interact with the existing functions/methods of Synth Dexed, but who knows... Let me see if there are some part of code that may be responsible for the issue you've described.

@frank-que
Copy link

Hi @arsamus, I'll try to check (after Silverstone GP) if I've made something wrong. ;)

@frank-que
Copy link

@arsamus, you're right, I've tested again copying all file to SD and now it works as expected.
Probably the rush made me commit some mistakes.
Have a good evening!

@arsamus
Copy link
Contributor

arsamus commented Jul 3, 2022

That's good! Thanks!

@probonopd
Copy link
Owner Author

probonopd commented Aug 6, 2022

Fixed in aa5a7c7
Thanks @arsamus! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants