Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MIDI CC 120 (All Sound Off) and 123 (All Notes Off) #127

Merged
merged 4 commits into from
Apr 21, 2022

Conversation

probonopd
Copy link
Owner

Closes #126

@probonopd
Copy link
Owner Author

probonopd commented Apr 20, 2022

Turns out it wasn't as easy as that...

mididevice.cpp: In member function 'void CMIDIDevice::MIDIMessageHandler(const u8*, size_t, unsigned int)':
mididevice.cpp:201:22: error: 'class CMiniDexed' has no member named 'panic'
  201 |      m_pSynthesizer->panic (pMessage[2], nTG);
      |                      ^~~~~
mididevice.cpp:205:22: error: 'class CMiniDexed' has no member named 'notesOff'
  205 |      m_pSynthesizer->notesOff (pMessage[2], nTG);
      |                      ^~~~~~~~
make: *** [../circle-stdlib/libs/circle/Rules.mk:144: mididevice.o] Error 1
make: *** Waiting for unfinished jobs....

Need to define them in src/minidexed.h and implement them in src/minidexed.cpp first...

@probonopd
Copy link
Owner Author

@diysynth can you please test the build from https://github.com/probonopd/MiniDexed/suites/6197459086/artifacts/218456185 and report back whether it works for you as intended?

Thanks!

@probonopd
Copy link
Owner Author

@rsta2 looks about right?

@rsta2
Copy link
Contributor

rsta2 commented Apr 21, 2022

Yes.

@probonopd probonopd merged commit 47ad10c into main Apr 21, 2022
@probonopd probonopd deleted the feature-panic branch April 21, 2022 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support CC messages for All Sound Off and All Notes Off
2 participants