Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add call to set Serial options to prevent CR to CRLF conversion #311

Merged
merged 3 commits into from
Aug 25, 2022

Conversation

diyelectromusic
Copy link
Collaborator

Initial attempt at a fix for #282

Grateful if someone could review, test and advise...

Kevin

@probonopd
Copy link
Owner

I see that as part of #287 @BenZonneveld would like to merge a private copy of Circle's serial.h, which I would like to avoid if possible, in order not to have the burden of maintenance. Does this PR the same thing that the patched serial.h does in #287?

@probonopd probonopd mentioned this pull request Jul 17, 2022
@diyelectromusic
Copy link
Collaborator Author

diyelectromusic commented Jul 18, 2022

I see that as part of #287 @BenZonneveld would like to merge a private copy of Circle's serial.h, which I would like to avoid if possible, in order not to have the burden of maintenance. Does this PR the same thing that the patched serial.h does in #287?

Yes - this is the way to solve this one. I'm afraid that that change to serial.h has just changed the actual constant definition which has fundamentally changed the options available in the serial driver to remove this! I really strongly suggest we don't do things like that... :)

We should also really discourage slipping in changes like this to unrelated bugs/issues...

@probonopd probonopd merged commit dcbd04c into probonopd:main Aug 25, 2022
@probonopd
Copy link
Owner

Merged this for now; please let me know if the merge causes any trouble for you. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants