Implement IgnoreAllNotesOff=1

[probonopd]

Implement IgnoreAllNotesOff=1 in minidexed.ini, closes #356

According to https://community.cantabilesoftware.com/t/roland-d-50-midi-cc-123-all-notes-off/2157/6, certain Roland devices send CC 123 ("All Notes Off") when the last key is released. This is probably a bug or a misinterpretation of the MIDI standard by Roland at the time.

Apparently Roland owners just filter out CC 123.

[probonopd]

Please test MiniDexed_2022-10-03-dc1a0e0

Set IgnoreAllNotesOff=1 in minidexed.ini.

[diyelectromusic]

Did you see my note that actually, we ought to be ignoring AllNotesOff when in Omni mode? If we do that, the filtering probably isn't required, as it would only apply to single channels anyway?

[probonopd]

Not sure I understand what you are saying. Let's assume the Roland keyboard is set to Channel 1. Wouldn't we stil have to filter out the AllNotesOff?

[diyelectromusic]

Not sure I understand what you are saying. Let's assume the Roland keyboard is set to Channel 1. Wouldn't we stil have to filter out the AllNotesOff?

Yes, but I think in that case it would work ok as the Roland, although it sends it more than it should, still only sends it when all notes on that channel (i.e. channel 1) are really off (as I understand things)? The problem is when you have several TGs listening to the messages so they all process AllNotesOff even if not actually part of their stream of notes? I could be mistaken, but that was how I interpreted the problem and what the Roland seems to be doing...?

But if all TGs are listening on channel 1 anyway, then shouldn't they all be tracking the NoteOff messages and so all legitimately respond to AllNotesOff correctly? The problem is if any TGs are on OMNI mode, then they'll all see the message?

Note sure, but as it is a channel message, I'd have thought it would only apply to the channel being listened on?

[diyelectromusic]

Ok, I see this has now been merged in. I still think we have a bug here though in that in Omni mode, AllNotesOff should be ignored regardless of any config setting...? But I'd like someone to check my reading of the MIDI spec!? :)

(and I still wonder then if that would mean this issue wouldn't apply - but if you want a config setting to ignore it too, then ok I guess?)

Kevin