Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uimenu: Add "Save > Performance" function #72

Merged
merged 2 commits into from
Apr 5, 2022
Merged

uimenu: Add "Save > Performance" function #72

merged 2 commits into from
Apr 5, 2022

Conversation

rsta2
Copy link
Contributor

@rsta2 rsta2 commented Apr 5, 2022

  • Saves the performance config to performance.ini
  • Comments in an existing file will be overwritten (!!!)
  • Function displays "Completed" and returns to "Save" menu

* Saves the performance config to performance.ini
* Comments in an existing file will be overwritten
* Function displays "Completed" and returns to "Save" menu
@probonopd
Copy link
Owner

Thanks @rsta2. Can you have a look at the confliciting files please?

@rsta2
Copy link
Contributor Author

rsta2 commented Apr 5, 2022

Done.

@probonopd
Copy link
Owner

...and tested successfully 👍

@probonopd probonopd merged commit f03ff27 into probonopd:main Apr 5, 2022
@probonopd
Copy link
Owner

Documentation updated.

@rsta2 rsta2 deleted the save-performance branch April 5, 2022 18:46
@probonopd
Copy link
Owner

Just an idea, could https://github.com/benhoyt/inih allow us to preserve comments when saving?https://github.com/dwhinham/mt32-pi is using it.

@rsta2
Copy link
Contributor Author

rsta2 commented Apr 19, 2022

Probably possible, but won't be done by myself. See #89.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants