uimenu: Add "Save > Performance" function #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rsta2
commented
Apr 5, 2022
rsta2
commented
- Saves the performance config to performance.ini
- Comments in an existing file will be overwritten (!!!)
- Function displays "Completed" and returns to "Save" menu
* Saves the performance config to performance.ini * Comments in an existing file will be overwritten * Function displays "Completed" and returns to "Save" menu
|
Thanks @rsta2. Can you have a look at the confliciting files please? |
|
Done. |
|
...and tested successfully 👍 |
|
Documentation updated. |
|
Just an idea, could https://github.com/benhoyt/inih allow us to preserve comments when saving?https://github.com/dwhinham/mt32-pi is using it. |
|
Probably possible, but won't be done by myself. See #89. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.