Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signal chain in float32_t #73

Merged
merged 7 commits into from
Apr 8, 2022
Merged

Signal chain in float32_t #73

merged 7 commits into from
Apr 8, 2022

Conversation

probonopd
Copy link
Owner

@probonopd probonopd commented Apr 7, 2022

Closes #71

@dcoredump
Copy link
Contributor

Now I got upstream merged into my fork and switched the complete audio signal path into type float32_t. MiniDexeds output seems to be louder now (without clipping). The reverb still has a noisy tail, but I think this is a problem of the PWM output. I hope I can build a setup with a PCM5102A soon.

@probonopd probonopd merged commit f98f5db into probonopd:main Apr 8, 2022
@probonopd
Copy link
Owner Author

Thanks @dcoredump. Significant improvement. Tested good with HDMI on RPi 2.

@rsta2
Copy link
Contributor

rsta2 commented Apr 8, 2022

CXXFLAGS += -DARM_MATH_NEON -DHAVE_NEON in Synth_Dexed.mk has no effect. Use DEFINE += -DARM_MATH_NEON -DHAVE_NEON instead to define these macros.

@dcoredump
Copy link
Contributor

CXXFLAGS += -DARM_MATH_NEON -DHAVE_NEON in Synth_Dexed.mk has no effect. Use DEFINE += -DARM_MATH_NEON -DHAVE_NEON instead to define these macros.

Thanks @rsta2 .

You mentioned this earlier and I forgot to fix this in my fork.

@rsta2
Copy link
Contributor

rsta2 commented Apr 9, 2022

I did some "code review" to learn about the changes. I think ProcessSound() without ARM_ALLOW_MULTI_CORE for the RPi 1 produces Stereo audio now, but is initialized for Mono here. That does not match. It's good that the output is much louder now. For what is the file src/minidexed.cpp.O?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit final sound processing stages
3 participants