Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention apkstudio in list of projects. #433

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Mention apkstudio in list of projects. #433

merged 1 commit into from
Apr 14, 2020

Conversation

vaibhavpandeyvpz
Copy link
Contributor

No description provided.

@probonopd probonopd merged commit d091be1 into probonopd:master Apr 14, 2020
@probonopd
Copy link
Owner

Thank you @vaibhavpandeyvpz

@probonopd
Copy link
Owner

probonopd commented Apr 14, 2020

Hi @vaibhavpandeyvpz,

when running the AppImage, getting

You need to download some 3rd-party applications/files and place them in proper directory for APK Studio to work.

All the things mentioned in https://github.com/vaibhavpandeyvpz/apkstudio#requirements should be bundled inside the AppImage, so that the user does not need to download additional things, just the AppImage.

An AppImage should never require the user to download/install anything else. In other words, AppImages shall not have dependencies other than what comes with the default installation of common mainstream Linux distributions.

Reference:
AppImage/appimage.github.io#458 (this has been preventing APK Studio from passing the AppImageHub test for 2 years)

@vaibhavpandeyvpz vaibhavpandeyvpz deleted the patch-1 branch April 14, 2020 06:59
@vaibhavpandeyvpz
Copy link
Contributor Author

This has been discussed earlier as APK Studio uses some other 3rd-party tools to fulfill its purpose which if bundled within APK Studio, would require repackaging of AppImage to update them. If this is a requirement, I would opt-out of AppImageHub. Having those dependencies specified by user allows them to swap out as per their requirement.

@probonopd
Copy link
Owner

OK, I understand. Well, at least the application doesn't just crash but at least does something (show a message), so I will leave it as is. Thanks @vaibhavpandeyvpz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants