Updated the ProbotOctokit.defaults() initialization with hotfix #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initialization of Probot instance with Octokit parameter is corrected per issue: probot/probot#2039 (comment)
|
Any maintainers/reviewers to take a look at it please? Thank you. |
wolfy1339
reviewed
Aug 18, 2024
| @@ -5,6 +5,8 @@ import nock from "nock"; | |||
| // Requiring our app implementation | |||
| import myProbotApp from "../src/index.js"; | |||
| import { Probot, ProbotOctokit } from "probot"; | |||
| // Requiring the OctokitOptions for ProbotOctokit.defaults() | |||
| import {OctokitOptions} from "probot/lib/types"; | |||
There was a problem hiding this comment.
You shouldn't use internal entrypoints like this.
TypeScript can infer these types anyways.
In a future major version, these won't be accesssible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialization of Probot instance with Octokit parameter is corrected per issue: probot/probot#2039 (comment)
I propose this PR in order to address this issue, even though it's a hotfix.