Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for JDK 17 and JDK 21 #119

Merged
merged 5 commits into from
Aug 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/build-java.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,13 @@ jobs:
# don't cancel running jobs even if one fails
fail-fast: false
matrix:
# java 17 fails: Fatal error compiling: java.lang.IllegalAccessError: class lombok.javac.apt.LombokProcessor (in unnamed module @0x2fcad999) cannot access class com.sun.tools.javac.processing.JavacProcessingEnvironment (in module jdk.compiler) because module jdk.compiler does not export com.sun.tools.javac.processing to unnamed module @0x2fcad999
java: [8, 11]
java:
- 17
- 21

steps:
- uses: actions/checkout@v4
- name: Set up JDK
uses: actions/setup-java@v4
- uses: actions/setup-java@v4
with:
java-version: ${{ matrix.java }}
distribution: 'zulu'
Expand Down
9 changes: 7 additions & 2 deletions java/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,12 @@

## Requirements

> JDK 8 or JDK 11
To build and run, use:
> JDK 17 or JDK 21

> [!NOTE]
> May work with older versions of JDK, but it has not been tested


## Build

Expand Down Expand Up @@ -31,4 +36,4 @@ java -jar target/bpmn-layout-generator-*-jar-with-dependencies.jar \
--input-type=CSV \
--output=<path_to_output_file> \
csv/PatientsProcess/nodeSimple.csv csv/PatientsProcess/edgeSimple.cs
```
```
2 changes: 1 addition & 1 deletion java/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<dependency>
<groupId>org.projectlombok</groupId>
<artifactId>lombok</artifactId>
<version>1.18.12</version>
<version>1.18.34</version>
<scope>provided</scope>
</dependency>
<dependency>
Expand Down
Loading