Add log4j2 logger implementation #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ok to me to use a log lib over a custom implementation for now. As @baptistemesta mentioned in a commit of this PR, I suggest we later review/avoid external lib usage to reduce the footprint of our implementation if we want to embed it easily in other products. If you agree @baptistemesta, I will also update the App class to use log4j2 (instead of poorly managed stdout calls) for consistency |
👍 |
I choosed log4j2 api instead of slf4j to have the lambda parameters available. I think it could still work with slf4j by using the log4j-to-slf4j binding ( to be verified ) If it does not work well I'll revert that to plain slf4j api I included the implementation of the logger directly in the app. This might not be the case if the project is split in an app + a lib examples of logs produce when activating debug: ``` 17:44:48.669 [main] DEBUG io.process.analytics.tools.bpmn.generator.algo.ShapeLayouter - Adding step3: Diagram: +-------+ |step1 | |step2 | |step3 | +-------+ 17:44:48.671 [main] DEBUG io.process.analytics.tools.bpmn.generator.algo.ShapeLayouter - Adding step4: Diagram: +--------------+ |step1 | |step2 step4 | |step3 | +--------------+ 17:44:48.672 [main] DEBUG io.process.analytics.tools.bpmn.generator.algo.ShapeLayouter - Adding step5: Diagram: +--------------+ |step1 | |step2 step4 | | step5 | |step3 | +--------------+ ```
baptistemesta
force-pushed
the
add_logger_impl
branch
from
26f17ba to
fd85145
Compare
tbouffard
added
the
chore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #26
(for no good reasons :) )