Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(shape name): handle null values #41

Merged
merged 2 commits into from
May 28, 2020
Merged

fix(shape name): handle null values #41

merged 2 commits into from
May 28, 2020

Conversation

tbouffard
Copy link
Member

Reproduced with C.1.0
Avoid

  • NullPointerException in ASCIIExporter
  • displaying 'null' shape label in SVGExporter

@tbouffard
fix(shape name): handle null values
c84c561 
Reproduced with C.1.0
Avoid
  - NullPointerException in ASCIIExporter
  - displaying 'null' shape label in SVGExporter
@baptistemesta baptistemesta merged commit 0db6f1d into master May 28, 2020
@baptistemesta baptistemesta deleted the fix/avoid_npe_on_null_shape_name branch May 28, 2020 07:43
@tbouffard tbouffard added the bug Something isn't working label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baptistemesta baptistemesta Awaiting requested review from baptistemesta

@oanesini oanesini Awaiting requested review from oanesini

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbouffard @baptistemesta