add csv node and edge from R data "Patients" #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tbouffard
reviewed
Jun 4, 2020
...src/main/java/io/process/analytics/tools/bpmn/generator/internal/BPMNDiagramRichBuilder.java
Outdated
Show resolved
Hide resolved
add test for ShapeSorter
add test with more complex discovery files avoid duplication in App2Test
constant for no namespace
Numeric values are not allowed in the BPMN schemas
tbouffard
force-pushed
the
feat/import_csv
branch
from
ef5728a to
aa4ecf1
Compare
tbouffard
approved these changes
Jul 16, 2020
baptistemesta
approved these changes
Jul 21, 2020
There was a problem hiding this comment.
Nice!
Only few remarks:
- The "hack" to copy string, I would remove that if it was not the source of the bug
- In other PR we should see if some library should be split, e.g. the CSV->BPMN conversion
- We should, as you said, have a better entry point for the app, i.e. option parsing an so on
- IMO, we should start to have a better API to interact with the BPMN model.
| import lombok.extern.log4j.Log4j2; | ||
|
|
||
| @Log4j2 | ||
| public class App2 extends App { |
There was a problem hiding this comment.
ℹ️ we should review the App entry point
| @@ -0,0 +1,113 @@ | |||
| package io.process.analytics.tools.bpmn.generator.input; | |||
There was a problem hiding this comment.
ℹ️ import would be more consistent with export
| } | ||
| public static Edge revertedEdge(Edge original) { | ||
| return original.toBuilder().from(original.getTo()).to(original.getFrom()).reverted(true).build(); | ||
| } | ||
|
|
||
| private static String copy(String s) { | ||
| return s + ""; // hack to ensure the returned string is equal to the provided one but doesn't have the same reference |
There was a problem hiding this comment.
❓ Do we really need to do that?
|
merging that despite the few remarks |
🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Render with
Patients Processnow provided as test resources in the repository (for label position issue, see #53)