feat(bpmn): generate edge waypoints #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbouffard
force-pushed
the
feat/add_edge_waypoints
branch
from
20068e1 to
1096a59
Compare
|
The
|
tbouffard
force-pushed
the
feat/add_edge_waypoints
branch
from
1096a59 to
7ff9ef7
Compare
wip waypoints computation in algo to model converter wip waypoints added to display model waypoints exported in SVG (no arrow) add additional point for orthogonal segment for BottomLeftToTopRight we must check if there is a shape obove the current one, to avoid overlapping intermediate waypoints exported in SVG (no arrow) intermediate waypoint: position depends on existence of shape above bpmn exporter: add edge waypoints bpmn exporter: bpmn shape and edge id based on bpmn element id no more generated, based on existing id for easier identification TopLeftToBottomRight: manage 1st vertical or horizontal SVGExporter: all edge segments have the same color + introduce opacity Remove system.out wip: add tests for computeEdgeDirection wip: add tests for computeEdgeDirection wip: add tests for computeEdgeDirection fix computeEdgeDirection_no_elements_between_from_and_top_with_from_on_bottom_left wip: add tests for computeEdgeDirection wip: add tests for computeEdgeDirection wip: add tests for computeEdgeDirection wip: add tests for computeEdgeDirection wip update computeWayPoints wip update computeWayPoints
tbouffard
force-pushed
the
feat/add_edge_waypoints
branch
from
27bea7e to
bea3ed5
Compare
|
We may probably add more unit tests but I consider this is ok for now |
baptistemesta
approved these changes
Oct 6, 2020
| .get(); // always exist, otherwise error occur on flow node generation | ||
| } | ||
|
|
||
| // visible for testing |
There was a problem hiding this comment.
ℹ️ IMO this method is static and visible for testing because it should be extracted in a specific class
| // +-----------------+ | ||
| assertThat(computeEdgeDirection(position(2, 2), position(1, 1), Grid.of(position(2, 1)))) | ||
| .isEqualTo(BottomRightToTopLeft_FirstHorizontal); | ||
| } |
There was a problem hiding this comment.
All theses tests with visual comment make the code easy to understand 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12
BPMNDiagram generated from A.2.0 with 20068e1
Notice that activity and event label positions should be adjusted with #53 (untouched by the changes proposed here)
