Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(app): Create a single entry point to generate diagram #55

Merged
merged 6 commits into from
Oct 8, 2020
Merged

feat(app): Create a single entry point to generate diagram #55

merged 6 commits into from
Oct 8, 2020

Conversation

baptistemesta
Copy link
Contributor

@baptistemesta baptistemesta commented Jul 24, 2020 •
edited
Loading

The entry point is now BPMNLayoutGenerator for programmatic usage and there is a single App:

Current usage:
see --help

Usage: App [-hV] [-o=OUTPUT] [-t=TYPE] [-u=TYPE] INPUT...
      INPUT...             Input file(s).
  -h, --help               Show this help message and exit.
  -o, --output=OUTPUT      Output file.
  -t, --input-type=TYPE    BPMN or CSV.
  -u, --output-type=TYPE   BPMN, SVG or ASCII.
  -V, --version            Print version information and exit.

@baptistemesta
feat(app): Create a single entry point to generate diagram
aadb958 
The entry point is now `BPMNLayoutGenerator`
@baptistemesta baptistemesta requested review from tbouffard and oanesini and removed request for tbouffard July 24, 2020 14:21
@baptistemesta
use picocli to generate cli
7f9317e 
see `--help`

```
Usage: App [-hV] [-o=OUTPUT] [-t=TYPE] [-u=TYPE] INPUT...
      INPUT...             Input file(s).
  -h, --help               Show this help message and exit.
  -o, --output=OUTPUT      Output file.
  -t, --input-type=TYPE    BPMN or CSV.
  -u, --output-type=TYPE   BPMN, SVG or ASCII.
  -V, --version            Print version information and exit.
```
@baptistemesta
fix test and create output file if not existing
e958c31
@baptistemesta baptistemesta added the enhancement New feature or request label Sep 24, 2020
@baptistemesta baptistemesta marked this pull request as ready for review September 24, 2020 15:44
tbouffard
tbouffard approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it and the picocli lib is great!
Nice work

@tbouffard tbouffard merged commit 1f371d3 into master Oct 8, 2020
@tbouffard tbouffard deleted the feat/review_app branch October 8, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard approved these changes

@oanesini oanesini Awaiting requested review from oanesini

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baptistemesta @tbouffard