Rework bpmn activity and event label positions #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbouffard
changed the title
tbouffard
changed the title
tbouffard
changed the title
tbouffard
force-pushed
the
feat/53-improve_bpmn_label_positions
branch
from
e994e05 to
c0956c9
Compare
BPMN vendor defaults are almost always setting the label at the center of the activity which is perfect. So no need to compute label bounds.
When we will support various task, detection will be managed by a dedicated method
tbouffard
force-pushed
the
feat/53-improve_bpmn_label_positions
branch
from
c0956c9 to
2e86330
Compare
This reverts commit c0956c9 This is not needed for now, so remove extra work.
tbouffard
changed the title
|
Looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not perfect but much better
closes #53
Rendering of the
A.2.0filePrevious rendering
Activity improvement
Event improvement