refactor(waypoints): split code and remove duplications #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbouffard
force-pushed
the
refactor/split_waypoints_computer_code
branch
from
072dfcc to
a8cac28
Compare
tbouffard
force-pushed
the
refactor/split_waypoints_computer_code
branch
from
a8cac28 to
91520b4
Compare
Extract code from WayPointsComputer: remove duplications and clarify responsibilities. This class now only does the orchestration. The waypoints description and conversion to display model are done in dedicated classes. Move display model domain classes to a dedicated package (clarify and remove cyclic dependencies). Rename some methods and classes to better express their purpose.
tbouffard
force-pushed
the
refactor/split_waypoints_computer_code
branch
from
91520b4 to
88f715e
Compare
|
I've not read everything but I get the idea. It looks more clear like that. |
tbouffard
added
chore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract code from WayPointsComputer: remove duplications and clarify
responsibilities. This class now only does the orchestration. The waypoints
description and conversion to display model are done in dedicated classes.
Move display model domain classes to a dedicated package (clarify and remove
cyclic dependencies).
Rename some methods and classes to better express their purpose.