Skip to content
This repository has been archived by the owner on Feb 28, 2021. It is now read-only.

Unit Testing #65

Open
spiray opened this issue Apr 25, 2018 · 5 comments
Open

Unit Testing #65

spiray opened this issue Apr 25, 2018 · 5 comments
Assignees

Comments

@spiray
Copy link
Contributor

spiray commented Apr 25, 2018

Hello, I think it will be very beneficial for this library to have unit tests which will automatically run on build and possibly use CI. What is the approach on this?

@spiray
Copy link
Contributor Author

spiray commented Jun 8, 2018

@MathuraMG @lm-n I wanted to get started with testing/CI as i think it will help a lot with making the contribution process smoother.

  • We will have tests
  • The CI can test each PR and then build.

Here are my questions -

  1. Do you have any preferences on Jest Vs. Mocha?
  2. Do you have any preference on a CI platform (CircleCI, TravisCI, or Other)? If one is chosen can one of you create an account that can be used?
  3. Is there a specific part of the project that should have tests written for it first?

Please let me know what you think. I will create a separate issue for CI.

Thanks!

@spiray spiray mentioned this issue Jun 8, 2018
1 task
@MathuraMG
Copy link
Collaborator

@spiray - Sorry for the delay! Last week was a bit of a mess.

  1. So I don't have a ton of perspective on this. I do know that Jest os probably the more popular choice. Do you have a specific preference to one over the other?
  2. Same as the above, really. Let's maybe stick to what os being used in the other p5 projects? Its circle CI right?
  3. Let's get started with the interceptors first?

@lm-n thoughts?

@MathuraMG
Copy link
Collaborator

hey @spiray - just wanted to follow up on this. Do the above comments make sense to start with the tests?

@spiray
Copy link
Contributor Author

spiray commented Jul 5, 2018

Yes! I am actually working on it right now. I am just setting up the environment based off of the way it is setup in the p5.js Sound library. Ill keep you updated.

@lm-n
Copy link
Member

lm-n commented Jul 5, 2018

Cool. I'll look at the PR soon. Just FYI https://github.com/processing/p5.js-web-editor uses Travis CI

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants