Started configuring test environment #89
Conversation
|
@MathuraMG @lm-n I have never configured a client side test environment and it seems that i missed a step or 2. Can i schedule a time with one or both of you to get the environment up and running and then i can write tests on my own...? |
|
@spiray - sure, does sometime in the evening this week work for you? |
|
Yeah, I can do either tonight after 7:30 or the same time on Thursday. |
|
@spiray I can do 9pm both days! |
|
@MathuraMG See the last 2 commits. Can you please merge these if they are all successful for you and then I will continue with the more complex tests within the |
|
@spiray Sorry I missed this! Doing it today |
| @@ -1,41 +1,77 @@ | |||
| /* global module */ | |||
There was a problem hiding this comment.
hey @spiray - question - is the tab space set to 4 on your editor or is it the lint settings?
There was a problem hiding this comment.
@MathuraMG I fixed it an recommitted and i set a new rule in the eslint config to only allow tabs and set tabs to 2 spaces in my editor. Do you have a better way of forcing the proper indentation?
There was a problem hiding this comment.
Setting it on eslint is perfect. I think if we make it "indent": [2, 2] then, it will be 2 spaces all over.
There was a problem hiding this comment.
OK, change made in last commit and i linted the tests and src folder. Let me know if you need anything else changed before merging. Thanks
|
@spiray - looks great! Just one super silly question on the tabbing. If you could just check that ill merge this asap |
Started configuring test environment based off of the p5,js Sound librarie's config to address #65.
@MathuraMG @lm-n please review this pr and commit and confirm that this is the path that you want me to go down before i continue.
gruntfile.js. These are just intital loads and they will need work.testfolder.I will start writing tests and push to this pr. Please let me know if you have any feedback or questions.
Thank you!