Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing examples for acceleration functions #2867

Merged
merged 1 commit into from
May 10, 2018
Merged

Add missing examples for acceleration functions #2867

merged 1 commit into from
May 10, 2018

Conversation

m90
Copy link
Contributor

@m90 m90 commented May 9, 2018

Also for #2865 - add examples for functions that didn't have example yet.

That being said: I am currently unable to get the reference up and running locally. After running grunt yui:dev I will see a layout and everything, but it won't be populated with any docs.

Do we have docs on how to get the docs running?

@Spongman
Copy link
Contributor

Spongman commented May 9, 2018

try grunt docs:dev

@lmccart lmccart merged commit a7f6426 into processing:master May 10, 2018
@lmccart
Copy link
Member

lmccart commented May 10, 2018

@Spongman is this the correct task? we should update the gruntfile if so, so it's more clear

@Spongman
Copy link
Contributor

this is the one i have been using since @outofambit added it in #2518. it builds the library & docs then starts the web serve and watches for change-triggered rebuilds.

@m90
Copy link
Contributor Author

m90 commented May 10, 2018

@Spongman docs:dev does not seem to exist in the repo that I forked / cloned yesterday:

frederik@fr-xps:~/projects/p5.js$ grunt docs:dev
Warning: Task "docs:dev" not found. Use --force to continue.

Aborted due to warnings.

Running yui:dev does what you describe (setting up server and watching) this very moment, when yesterday it only rendered an empty skeleton, so there might be a bug hidden in the tasks. Anyways, it looks like this: https://github.com/processing/p5.js/blob/master/developer_docs/inline_documentation.md#generating-documentation is up to date and correct.

@Spongman
Copy link
Contributor

yes, sorry i spaced. i was thinking of the npm task docs:dev which does indeed just run yui:dev just like you say.

@m90
Copy link
Contributor Author

m90 commented May 10, 2018

Yeah, I just noticed this very second that it's a npm task that also works just as expected for me. So it looks like all is well!

@m90 m90 deleted the m90-acceleration-examples branch May 10, 2018 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants